[3.x] Add viewport.get_camera_2d()
#69426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deozaan
force-pushed
the
get-camera-2d-3.x
branch
from
9af98d2 to
038e568
Compare
Deozaan
force-pushed
the
get-camera-2d-3.x
branch
4 times, most recently
from
eb30286 to
56933a3
Compare
|
Sorry, I'm not super familiar with working with git on large repositories with hundreds of contributors. I'm not sure what I did, but I broke something. I tried to update my repository to be compatible with the latest changes to this one and now many extra commits are showing up here. Can anyone explain to me what I did wrong, and more importantly, how to fix it? |
Deozaan
force-pushed
the
get-camera-2d-3.x
branch
from
b72083d to
44cf165
Compare
|
I think I fixed it. |
aaronfranke
reviewed
Jan 6, 2023
doc/classes/Camera2D.xml
Outdated
Comment on lines
63
to
68
| <method name="make_current"> | ||
| <return type="void" /> | ||
| <description> | ||
| Make this the current 2D camera for the scene (viewport and layer), in case there are many cameras in the scene. | ||
| </description> | ||
| </method> |
There was a problem hiding this comment.
Removing these methods breaks compatibility, so it can't be done in the stable 3.x branch.
Deozaan
force-pushed
the
get-camera-2d-3.x
branch
from
44cf165 to
a22eadd
Compare
aaronfranke
reviewed
Jan 6, 2023
doc/classes/Camera2D.xml
Outdated
| @@ -94,7 +94,7 @@ | |||
| <member name="anchor_mode" type="int" setter="set_anchor_mode" getter="get_anchor_mode" enum="Camera2D.AnchorMode" default="1"> | |||
| The Camera2D's anchor point. See [enum AnchorMode] constants. | |||
| </member> | |||
| <member name="current" type="bool" setter="_set_current" getter="is_current" default="false"> | |||
| <member name="current" type="bool" setter="set_current" getter="is_current" default="false"> | |||
There was a problem hiding this comment.
Changing this also breaks compat.
keep methods to preserve compatibility more compat fixes
Deozaan
force-pushed
the
get-camera-2d-3.x
branch
from
a22eadd to
6a38a1b
Compare
akien-mga
changed the title
viewport.get_camera_2d() in 3.x
akien-mga
changed the title
viewport.get_camera_2d() in 3.xviewport.get_camera_2d()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor here. Please guide me in pointing out anything I missed or correcting any mistakes I made. Thanks.
Backport of #38317 for 3.x.