Fix static object destructors being called on gpu selection with X11 #68345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 7, 2022
| @@ -208,7 +208,10 @@ int detect_prime() { | |||
| print_verbose("Couldn't write vendor/renderer string."); | |||
| } | |||
| close(fdset[1]); | |||
| exit(0); | |||
|
|
|||
| //quick_exit() is used because exit() will call destructors on static objects copied by fork() | |||
There was a problem hiding this comment.
Please amend the comment to use the same style as surrounding code (capitalized sentences ending with a period, space after //).
|
You seem to have typoed your email in your Git identity, so it's not attributed to your GitHub account: https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/68345.patch You can edit your Git email locally, then amend the commit with |
akien-mga
reviewed
Nov 7, 2022
akien-mga
approved these changes
Nov 9, 2022
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Rubonnek
added
cherrypick:3.5
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #68322
There is no need to call static object destructors on a child process that is used purely for determining the best GPU to use.