-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to customize launching position for every debug instance #67587
Conversation
0e89bfc
to
12392b8
Compare
12392b8
to
2691528
Compare
@bruvzg do you have time to review this pr? |
2691528
to
d25686c
Compare
ping @bruvzg |
See also godotengine/godot-proposals#3357 and #64913. |
Thanks for your information. I read the proposal and #64913. #64913 is different from this PR. This PR only controls the positions of windows and do not touch on debug identity. I also reviewed #64913 and left some comments. |
@Calinou Could this pr be merged? |
@clayjohn Could you also take a look of this PR? |
d25686c
to
cf19fb2
Compare
Fixed conflicts |
The code looks fine to me, but I have a feeling this change will break compatibility for projects that are already using this ProjectSetting. @bruvzg @akien-mga Are we okay with breaking compatibility here? |
It's an editor setting, so won't break actual projects and probably ok. |
I think these kind of settings should go through a proper "Run Configuration" widget (godotengine/godot-proposals#522 , godotengine/godot-proposals#522 (comment)), likely using project metadata instead of editor settings. |
It seems the implementation of #65753 is more general. Will |
It makes sense to move it to wherever we store the run configuration |
But it doesn't have explicit window placement options, right? |
Change
run/window_placement/rect_custom_position
to an array to support specify position of every debug instance.Now I can debug multiplayer instances without
Run & moving window & moving window & moving window & moving window
.Snapshot: