-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GDExtension] Implement support for typed arrays. #65817
Conversation
Does this supersede #64249? |
As usual, it will need rebase after godotengine/godot-cpp#841 merge to pass CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but I don't see what are the TypedArray related changes in TextServers?
This also the discussion on #64249 on how to handle this kind of generics in different languages. |
TextServer already was using TypedArrays (and was unbuildable for this reason), TS changes are to make it buildable as an extension again, but not directly related to TypedArray. |
The generics, like |
I'll merge even though the CI build with godot-cpp hasn't completed yet, to unblock other PRs (as the counterpart merged in godot-cpp breaks building against current Godot code until this is merged). |
Thanks! |
Exposes missing
Array
methods, and add typed arrays to the GDExtension JSON.godot-cpp
part - godotengine/godot-cpp#841