misc: add type annotation to platform.configure #65309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #65024 I added a type annotation to
configure()inplatform/macos/as a check for the changes made there, but the sentiment was that it should be a consistent thing across all platforms rather than a complementary change in the affected file.I reverted the annotations in #65024, just to keep there only the changes relevant for the fix itself, and separated the type annotations for all
platformdirectories into this PR, with all changes required to make mypy pass without errors.However without #64784 merged this is just a fix for current moment, and wont prevent any potential breaking without the automatic check running in CI.