Rename String plus_file to path_join
#65066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Aug 30, 2022
bruvzg
approved these changes
Aug 30, 2022
|
Thanks! |
chippmann
added a commit
to utopia-rise/godot-kotlin-jvm
that referenced
this pull request
Nov 15, 2022
chippmann
added a commit
to utopia-rise/godot-kotlin-jvm
that referenced
this pull request
Nov 16, 2022
chippmann
added a commit
to utopia-rise/godot-kotlin-jvm
that referenced
this pull request
Nov 22, 2022
* Fix compilation errors in export plugin * Comment rpc stuff fixes in #369 * Replace `plus_file` with `path_join`. See: godotengine/godot#65066 * Replace `call` with `callp` and `call_deferred` witch `call_deferredp`. See: godotengine/godot@d4433ae * Replace `Main::is_project_manager()` with `Engine::get_singleton()->is_project_manager_hint()`. See: godotengine/godot#52742 * Fix `save` overridden method structure * Add overrides for new pure virtual functions * Add overrides for missing pure virtual functions * Fix bottom panel * Fix import and tooltip * Implement missing function * Make `KotlinEditorExportPlugin` header only to make it compile. See: `GDExtensionExportPlugin` * Fix godot actions input * Fix wrong arch input * Rename osx to macos for platform input * Rename job matrix name for macos targets * Remove remaining `tools` inputs * Add setup vulkan sdk * Fix target * Replace all occurrences of osx with macos * Replace `OSX_ENABLED` with `MACOS_ENABLED` * Rename directory * Fix x86_64 binary name * Fix android export template builds * Replace `tools` with `editor` * Fix download binary name * Fix kotlin compilation errors (except rpc stuff from entry gen) * Fix template release target after rebase * Fix reference typos * Fix reference typos * fix: bring back kotlin_editor_export_plugin.cpp * Fix imports * Improve import path to match other occurrences * Fix wrong alignment Co-authored-by: Pierre-Thomas Meisels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion here: #54161 (comment)
I propose renaming it to
path_joinsince it joins two paths together. This method can be used for more than just files, soplus_fileisn't a very good name. It even works for URLs: