-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify usage of undo_redo in editor #65062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
RedoUndo
branch
3 times, most recently
from
September 5, 2022 14:21
6338f9f
to
67ceb94
Compare
|
Iniquitatis
reviewed
Nov 2, 2022
akien-mga
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making #59564 I noticed that undo usage in the editor is very inconsistent. Some classes use singleton, some have EditorData pointer, but most classes have "cached" UndoRedo pointer (now EditorUndoRedoManager), which is often set with
set_undo_redo()
. The thing is, it's always initialized with the singleton UndoRedo XD. And only leads to useless forward-declares and useless calls that pass global object lolThis PR is supposed clean that up. It removes all references to EditorUndoRedoManager in header files. Now the undo usage is
Ref<EditorUndoRedoManager> &undo_redo = EditorNode::get_undo_redo(); undo_redo->do_stuff()
consistently. I also fixed some code that didn't use the undoredo as reference. The cleanup is not complete though. There are many changes, so I'm going to split it into multiple PRs.