Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Use "param" instead of "code" to refer to parameters #64134

Merged
merged 1 commit into from
Aug 9, 2022
Merged

[doc] Use "param" instead of "code" to refer to parameters #64134

merged 1 commit into from
Aug 9, 2022

Conversation

asmaloney
Copy link
Contributor

Also fixes a couple of descriptions in Vector4.xml and Viewport.xml.

This is the first of several commits to fix all of the class XML docs.

(Work based on discussion with @YuriSizov.)

@asmaloney asmaloney requested a review from a team as a code owner August 9, 2022 01:35
@Calinou Calinou added this to the 4.0 milestone Aug 9, 2022
YuriSizov
YuriSizov suggested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Some additional nitpicks/language and formatting adjustments, but otherwise this is good!

doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/UndoRedo.xml Outdated Show resolved Hide resolved
doc/classes/XMLParser.xml Outdated Show resolved Hide resolved
doc/classes/XMLParser.xml Outdated Show resolved Hide resolved
doc/classes/XRPositionalTracker.xml Outdated Show resolved Hide resolved
doc/classes/XRPositionalTracker.xml Outdated Show resolved Hide resolved
doc/classes/XRServer.xml Outdated Show resolved Hide resolved
@asmaloney asmaloney mentioned this pull request Aug 9, 2022
Merged
@akien-mga akien-mga merged commit d11117d into godotengine:master Aug 9, 2022
@akien-mga
Copy link
Member

Thanks!

@asmaloney asmaloney deleted the doc-params branch August 9, 2022 21:00
This was referenced Aug 10, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@asmaloney @akien-mga @YuriSizov @Calinou