Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Basis Universal compressing with normal maps. #62718

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Fix Basis Universal compressing with normal maps. #62718

merged 1 commit into from
Jun 16, 2023

Conversation

Step-an
Copy link
Contributor

@Step-an Step-an commented Jul 4, 2022

Fix #61039.

@Step-an Step-an requested a review from a team as a code owner July 4, 2022 19:54
@Step-an Step-an force-pushed the fix_basic_universal_compressing_with_normal_maps branch from ce12fc6 to c97db0c Compare July 4, 2022 20:00
@YeldhamDev YeldhamDev added this to the 4.0 milestone Jul 4, 2022
@Calinou Calinou mentioned this pull request Jul 4, 2022
Closed
fire
fire reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything obviously wrong, but need to do the work to try the test cases and read the code to understand it.

In my other pr. I also changed this code. #59540

@aaronfranke aaronfranke changed the title Fix Basic Universal compressing with normal maps. Fix Basis Universal compressing with normal maps. Jul 5, 2022
@Step-an Step-an requested a review from fire July 7, 2022 18:45
@YuriSizov YuriSizov requested a review from a team February 12, 2023 20:58
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 12, 2023
@akien-mga akien-mga mentioned this pull request Jun 16, 2023
Closed
@akien-mga akien-mga modified the milestones: 4.1, 4.2 Jun 16, 2023
@clayjohn clayjohn force-pushed the fix_basic_universal_compressing_with_normal_maps branch from c97db0c to 56cfde3 Compare June 16, 2023 19:03
@clayjohn
Copy link
Member

I had to rebase to test this anyway so I pushed the rebase up to the PR branch. As described in #74035 I think this PR is the correct solution to the issue.

@akien-mga We can consider this for 4.1 now that it is rebased.

@akien-mga akien-mga modified the milestones: 4.2, 4.1 Jun 16, 2023
@akien-mga akien-mga merged commit a83eb16 into godotengine:master Jun 16, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@fire fire Awaiting requested review from fire

Assignees
No one assigned
Labels
bug topic:import topic:3d
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Normal map is incorrectly compressed when using Basis Universal compression mode
6 participants
@Step-an @clayjohn @akien-mga @fire @YuriSizov @YeldhamDev