Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for Android scoped storage #62459

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Jun 27, 2022

This was done by refactoring directory and file access handling for the Android platform so that any general filesystem access type go through the Android layer.
This allows us to validate whether the access is unrestricted, or whether it falls under scoped storage and thus act appropriately.

Main version of #51815

@m4gr3d m4gr3d added this to the 4.0 milestone Jun 27, 2022
@m4gr3d m4gr3d force-pushed the refactor_android_storage_handling_main branch 2 times, most recently from 5937958 to 5e6d54a Compare July 5, 2022 08:53
@m4gr3d m4gr3d marked this pull request as ready for review July 5, 2022 09:24
@m4gr3d m4gr3d requested review from a team as code owners July 5, 2022 09:24
@m4gr3d m4gr3d force-pushed the refactor_android_storage_handling_main branch from 5e6d54a to cfdccae Compare July 5, 2022 09:32
This was done by refactoring directory and file access handling for the Android platform so that any general filesystem access type go through the Android layer.
This allows us to validate whether the access is unrestricted, or whether it falls under scoped storage and thus act appropriately.
@m4gr3d m4gr3d force-pushed the refactor_android_storage_handling_main branch from cfdccae to f9c1929 Compare July 5, 2022 10:00
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit 4e7223c into godotengine:master Jul 5, 2022
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the refactor_android_storage_handling_main branch July 5, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants