-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update android:targetSdkVersion from 30 to 31 #62297
Update android:targetSdkVersion from 30 to 31 #62297
Conversation
@akien-mga If we're planning to have more 3.4.x releases then the scoped storage PR should also be included in the 3.4.x branch otherwise we'll introduce too significant of a delta making future storage related fixes harder to merge. The scoped storage update itself doesn't break compat so it can be backported to the 3.4.x branch. |
@m4gr3d I don't think it's worth it, 3.4.5 will likely be the last 3.4 release and we normally don't add new features/change behaviour in a stable branch, especially not in the last point release. We just need 3.4.x to stay usable for existing published games. People who need scoped storage should just move to 3.5. |
Then yes, we should merge this change for 3.4.5 then! You can cherry-pick this change in the 3.5 branch as well. If we merge #51815, it'll just override/complement the changes made here. |
Looks good! Could you squash the commits? See PR workflow for instructions. |
Starting in August 2022, new apps will need to target API level 31 (Android 12) or higher and adjust for behavioral changes. Read more here: https://developer.android.com/google/play/requirements/target-sdk
155d3f4
to
ec6d5d6
Compare
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 3.5. |
Cherry-picked for 3.4.5. |
Thank you guys! I hope to contribute more! |
Starting in August 2022, new apps will need to target API level 31 (Android 12) or higher and adjust for behavioral changes.
Read more here: https://developer.android.com/google/play/requirements/target-sdk
This change should be easily cherry-picked for
3.x
and maybe release on3.5
before release the stable version.Btw this is my first PR on Godot 😁, if i need to do other thing that i don't know to this be merged please let me know.