[Editor] Fix GDExtension GNU/Linux export. #61352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 24, 2022
| for (const String &E : p_features) { | ||
| tags.append(E); | ||
| } | ||
| print_line(vformat("Couldn't export extension: %s. No suitable library found for export flags: %s", p_path, String(", ").join(tags))); |
There was a problem hiding this comment.
I wasn't sure, there might be some platforms where you don't need a specific extension (e.g. webrtc-native on HTML5), but I guess those cases are better handled via the export filters. I'll make it an error for now.
This is in line with what's reported by the `OS` class on GNU/Linux, and is required by the extension exporter to identify the correct library. For BSD, we should either finish splitting the platform (into platform/bsd) or register a separate exporter with OS name BSD and proper templates detection.
akien-mga
approved these changes
May 24, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
EditorExportPlatformLinuxBSDos_name toLinux:This is in line with what's reported by the
OSclass on GNU/Linux, and is required by the extension exporter to identify the correct library to export.For BSD, we should either finish splitting the platform (into platform/bsd) or register a separate exporter with OS name BSD and proper templates detection.