Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StreamPeerSSL.get_stream #61339

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented May 23, 2022

There was no way to print the host of a StreamPeerSSL, for example for debugging or logging error messages.

Currently, it might be possible to store the original stream passed into connect_to_stream, but keeping track of two values is prone to error, and makes writing GDScript harder.

@lyuma lyuma requested review from a team as code owners May 23, 2022 22:11
@lyuma lyuma force-pushed the streampeerssl_get_stream branch from f3e2499 to 9f07e34 Compare May 23, 2022 22:12
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 ! Needs a fix in the documentation XML, then it's good to go as soon as CI passes.

<return type="StreamPeer" />
<description>
Returns the underlying [StreamPeer] connection, used in [ref accept_stream] or [ref connect_to_stream].
</description>
Copy link
Member

@akien-mga akien-mga May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag is method, not ref.

@lyuma lyuma force-pushed the streampeerssl_get_stream branch from 9f07e34 to 7e28385 Compare June 1, 2022 16:54
@akien-mga akien-mga merged commit 6cd730e into godotengine:master Jun 1, 2022
@akien-mga
Copy link
Member

Thanks!

@lyuma lyuma deleted the streampeerssl_get_stream branch May 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants