-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnimationTree Advance Expressions #61196
Add AnimationTree Advance Expressions #61196
Conversation
@neikeq This is erroring on mono and I can't figure out why. |
ee44989
to
70ab9c6
Compare
On master these constants were swapped.
|
70ab9c6
to
9892123
Compare
0129687
to
f7c5f61
Compare
f7c5f61
to
d911edb
Compare
d911edb
to
1e9a6bb
Compare
At a glance it looks ok to me. |
This is probably a bit tricky at this stage with multiple co-authors not all familiar with all changes, but it would have been nice if the changes in this PR could have been two separate PRs or at least commits, one for the core/expression changes and one actually adding the AnimationTree advance expressions. This would make the code and history more readable and the review of the core and animation parts easier to do for respective teams. |
5539303
to
2d78b4a
Compare
2d78b4a
to
fea3d6b
Compare
Since this has been stuck. I'm motivated! |
Pulled out Add a const call mode to Object, Variant and Script. #62468 Edited: Resolved a few comments in the other pr. The second part is at: https://github.com/V-Sekai/godot/tree/animtree-expressions-separated |
fea3d6b
to
4c030d4
Compare
@TokageItLab Any last reviews? |
Sorry, I am not familiar with StateMachine, so I cannot review with confidence. |
Allows specifying an expression as a condition for state machine transitions. This gives much greater flexibility for creating complex state machines. By directly interfacing with the script code, it is possible to create complex animation advance condition for switching between states. Ensure assigning AnimationTreeStateMachineTransition base expression node in editor is relative to current AnimationTree node. Allow setting an expression base node on the AnimationTree itself. Co-Authored-By: reduz <[email protected]>
4c030d4
to
75a8606
Compare
Thanks! |
Remake of Reduz's pull request.
This gives much greater flexibility for creating complex state machines. By directly interfacing with the script code, it is possible to create complex animation advance condition for switching between states.
Ensure assigning AnimationTreeStateMachineTransition base expression node in editor is relative to current AnimationTree node.
Allow setting an expression base node on the AnimationTree itself
Allows specifying an expression as a condition for state machine transitions.
Co-Authored-By: reduz [email protected]
Part of the V-Sekai group. https://github.com/v-sekai