Move editor class and plugin registrations to a dedicated file #60686
+268
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trollodel
changed the title
trollodel
force-pushed
the
move_editor_registration
branch
from
9c2145e to
5d721a7
Compare
trollodel
force-pushed
the
move_editor_registration
branch
from
5d721a7 to
765efc1
Compare
trollodel
force-pushed
the
move_editor_registration
branch
from
765efc1 to
8f8e948
Compare
trollodel
force-pushed
the
move_editor_registration
branch
2 times, most recently
from
176e38b to
62ed393
Compare
trollodel
force-pushed
the
move_editor_registration
branch
from
62ed393 to
7517745
Compare
akien-mga
approved these changes
Nov 18, 2022
|
Thanks! |
Anutrix
reviewed
Nov 19, 2022
| @@ -7375,63 +7257,7 @@ EditorNode::EditorNode() { | |||
| raise_bottom_panel_item(AnimationPlayerEditor::get_singleton()); | |||
|
|
|||
| add_editor_plugin(VersionControlEditorPlugin::get_singleton()); | |||
|
|
|||
| // This list is alphabetized, and plugins that depend on Node2D are in their own section below. | |||
| add_editor_plugin(memnew(AnimationTreeEditorPlugin)); | |||
| add_editor_plugin(memnew(AudioBusesEditorPlugin(audio_bus_editor))); | |||
There was a problem hiding this comment.
Why wasn't AudioBusesEditorPlugin moved?
There was a problem hiding this comment.
Mostly because of the parameter. Also, the VS plugin (added above) was left there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #60684.
Follow up of #58136. See this comment.
Move
EditorNode::register_editor_typesandEditorNode::register_editor_typesto a dedicated file, like core, servers, and scene.Move most editor plugin creation in
register_editor_typesand useEditorPlugins::add_by_typefor registering it. This is the same method used by modules to register their plugins.Note that I increased
EditorPlugins::MAX_CREATE_FUNCSto 128 because this PR uses 56 EditorPlugins plugins slots out of 64, leaving only 6 slots for modules.The new methods no longer are methods of EditorNode. For this reason,
EditorNode::cleanupis created and called inunregister_editor_types.This allows to change most plugins without recompiling the giant EditorNode.