-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary MO translation file support. #59276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I assume that to actually benefit from this in editor builds we'd need to add a buildsystem step using gettext to generate the MO files? (Probably optional, if gettext is found.)
Thanks! |
Yes, we have to run |
Both should be easy to backport, but 3.x editor use smaller number of fonts so impact would be less as well. |
I have not fully tested it, but it seems to remove almost 7 MB, so probably worth it - #59522 |
Adds support for binary MO files (same features, but smaller).
TODO:
Also, added an extra check for text PO loader, to prevent crash in case of invalid "Plural-Forms" string.
Node: with the currently enabled editor / class-ref translations, converting them to MO can decrease editor binary size by 1.6 MB (probably substantially more if incomplete translations are included).