Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename several transform built-ins in shaders #59268

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Rename several transform built-ins in shaders #59268

merged 1 commit into from
Mar 18, 2022

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Mar 18, 2022 •
edited
Loading

Remake #59092

WORLD_MATRIX rename to MODEL_MATRIX
WORLD_NORMAL_MATRIX rename to MODEL_NORMAL_MATRIX

CAMERA_MATRIX rename to INV_VIEW_MATRIX
INV_CAMERA_MATRIX rename to VIEW_MATRIX

@Chaosus Chaosus requested review from a team as code owners March 18, 2022 09:11
@Chaosus Chaosus added this to the 4.0 milestone Mar 18, 2022
clayjohn
clayjohn approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga merged commit ef24e95 into godotengine:master Mar 18, 2022
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_renames2 branch March 19, 2022 06:34
@Chaosus Chaosus mentioned this pull request Mar 19, 2022
Merged
@novaplusplus
Copy link
Contributor

Need to get the docs updated to reflect this - took me awhile to figure out why my shaders blew up!

@clayjohn
Copy link
Member

It looks like godotengine/godot-docs#5700 mistakenly only updated the fragment shader part of the docs, the same changes are still needed for the vertex shader section

@Chaosus Chaosus mentioned this pull request Apr 29, 2022
Closed
@jejay jejay mentioned this pull request Aug 27, 2022
Closed
@lucho1 lucho1 mentioned this pull request Jun 12, 2023
Closed
@akien-mga akien-mga mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:shaders
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Chaosus @akien-mga @novaplusplus @clayjohn