Changed TileMap::set_cell alternative_tile default value to 0 #58659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IgorKordiukiewicz
commented
Mar 1, 2022
•
IgorKordiukiewicz
commented
- Fixes New TileSet editor: set_tile only writes NULL #57833
|
You need to change the default value also where the method is bound: Line 3625 in 3f9a601 |
IgorKordiukiewicz
force-pushed
the
set_tile_alternative_tile_default_param
branch
from
85a777d to
a387bc3
Compare
|
Updated |
groud
reviewed
Mar 2, 2022
doc/classes/TileMap.xml
Outdated
| <description> | ||
| Sets the tile indentifiers for the cell on layer [code]layer[/code] at coordinates [code]coords[/code]. Each tile of the [TileSet] is identified using three parts: | ||
| - The source identifier [code]source_id[/code] identifies a [TileSetSource] identifier. See [method TileSet.set_source_id], | ||
| - The atlas coordinates identifier [code]atlas_coords[/code] identifies a tile coordinates in the atlas (if the source is a [TileSetAtlasSource]. For [TileSetScenesCollectionSource] it should be 0), | ||
| - The alternative tile identifier [code]alternative_tile[/code] identifies a tile alternative the source is a [TileSetAtlasSource], and the scene for a [TileSetScenesCollectionSource]. | ||
| - The alternative tile identifier [code]alternative_tile[/code] identifies a tile alternative the source is a [TileSetAtlasSource], and the scene for a [TileSetScenesCollectionSource]. Passing -1 will clear the tile. |
There was a problem hiding this comment.
I don't think this precision should be here. You have to set all three args to -1, Vector2i(-1,-1) and -1 to clear a tile, not only the last one.
|
I am not strictly against the change, but it annoys me that you would have to call If we want to change that argument default value we should likely add an |
IgorKordiukiewicz
force-pushed
the
set_tile_alternative_tile_default_param
branch
from
a387bc3 to
d3b03ef
Compare
|
Updated |
IgorKordiukiewicz
force-pushed
the
set_tile_alternative_tile_default_param
branch
from
d3b03ef to
466644f
Compare
akien-mga
reviewed
Mar 2, 2022
IgorKordiukiewicz
force-pushed
the
set_tile_alternative_tile_default_param
branch
from
466644f to
8f49150
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.