Allow using CanvasItemMaterial in the TileSet editor #58544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Remember to update docs. |
Calinou
force-pushed
the
tileset-source-allow-canvasitemmaterial
branch
from
a92057b to
49caba9
Compare
Done. I haven't managed to create a testing project for this yet (I'm getting a bunch of errors trying to use a tileset image with only 1 tile). |
KoBeWi
reviewed
Jun 20, 2022
KoBeWi
approved these changes
Jun 20, 2022
Previously, only ShaderMaterial overrides could be added.
Calinou
force-pushed
the
tileset-source-allow-canvasitemmaterial
branch
from
49caba9 to
b3fe273
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only ShaderMaterial overrides could be added.
Note: Not tested yet, I'll make a quick setup to make sure it works as expected.
This closes #58541.