Expose String::bin_to_int64 over to GDScript
#56368
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubonnek
changed the title
String::bin_to_int64 over to GDScript
|
I don't think we should undo the work I did in #43978. It's nicer to just have it automatically handle the prefix, we don't need a parameter for it. Meaning if we want the behavior of allowing both prefixed and non-prefixed in 3.x, we could just backport the ability to automatically determine the prefix, but it'd be a bit tricky to do this without breaking compatibility with 3rd-party modules. It'd be weird to add a parameter to 3.x that isn't present in 4.0. |
|
I won't expose the parameter on GDScript then. Edit: |
Rubonnek
force-pushed
the
expose-bin-to-int
branch
from
329e9b5 to
696a8fd
Compare
Rubonnek
force-pushed
the
expose-bin-to-int
branch
from
696a8fd to
91fc3e0
Compare
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #56363Patch not needed on
master.Edit: Rebased patch now that #56363 is merged.