-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add highlight option for Labels #5514
Add highlight option for Labels #5514
Conversation
This commit adds a new highlight option to Label to provide simple word highlighting as seen in many games. To highlight a word, just put & in front of it. The highlight color can be selected and this feature is disabled by default for backwards compability. (So you can enable it by changing the Label's highlight_enabled property)
Isn't just easier to use a RichTexLabel or am I missing something? |
I tried a RichTextLabel, but I found these two issues:
And I think this is a basic feature for which a RichTextLabel would be overkill. |
This sounds like a bug which deserve its own issue.
You can H-align with BBCode. V-align is not possible, but maybe it can be implemented. Also you can work around that with containers. My concern is that adding "just a simple feature" every time will eventually make it too complex. |
Yes, the DF blur is definitely an own issue, I just hadn't the time to submit it. I just implemented this, because I needed it for my game. Timo Schwarzer https://timoschwarzer.com On Fri, Jul 01, 2016 at 5:43 PM, George Marques < [email protected] [[email protected]] > wrote: This sounds like a bug which deserve its own issue. I can't H and V Align the t. You can H-align with BBCode. V-align is not possible, but maybe it can be implemented. Also you can work around that with containers. My concern is that adding "just a simple feature" every time will eventually make it too complex. |
Let's fix RichTextLabel instead On Fri, Jul 1, 2016 at 12:48 PM, Timo Schwarzer [email protected]
|
👍 |
Do we have an issue about fixing RichTextLabel? If so this PR could be closed, as it won't be merged I suppose. |
I'll create one. |
This commit adds a new highlight option to Label to provide simple word highlighting as seen in many games.
To highlight a word, just put & in front of it. The highlight color can be selected
and this feature is disabled by default for backwards compability. (So you can enable it by changing the Label's highlight_enabled property)
(This time without unrelated commits 😅)
Test project:
gd-hint-label-test.tar.gz