Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport GradientTexture2D to 3.x #54824

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Backport GradientTexture2D to 3.x #54824

merged 1 commit into from
Jan 7, 2022

Conversation

AaronRecord
Copy link
Contributor

3.x version of #53234

@AaronRecord AaronRecord changed the title Add GradientTexture2D Backport GradientTexture2D to 3.x Nov 10, 2021
@AaronRecord AaronRecord changed the title Backport GradientTexture2D to 3.x Backport GradientTexture2D to 3.x Nov 10, 2021
@Chaosus Chaosus added this to the 3.5 milestone Nov 10, 2021
@Xrayez
Copy link
Contributor

Xrayez commented Nov 10, 2021 •
edited
Loading

Note to self: if this is merged, then I'll have to remove GradientTexture2D in Goost, hence mission accomplished! 🙂

Also, it's quite wild to see four contributors co-authored now for a single feature, I've never seen this throughout my time contributing to Godot, crazy! 😅

@AaronRecord AaronRecord force-pushed the backport-gradient-texture-2d branch 2 times, most recently from 31d0b1a to 3d6a9f9 Compare November 11, 2021 01:36
@Geometror @MarianoGnu
@Xrayez @AaronRecord
Add GradientTexture2D
97074dc 
Co-authored-by: Mariano Javier Suligoy <[email protected]>
Co-authored-by: Andrii Doroshenko <[email protected]>
@AaronRecord AaronRecord force-pushed the backport-gradient-texture-2d branch from 3d6a9f9 to 97074dc Compare November 11, 2021 02:00
AaronRecord
AaronRecord commented Nov 11, 2021
View reviewed changes
Copy link
Contributor Author

@AaronRecord AaronRecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some review comments with the noteworthy changes I had to make from the 4.0 branch

scene/resources/texture.cpp Show resolved Hide resolved
scene/resources/texture.cpp Show resolved Hide resolved
scene/resources/texture.cpp Show resolved Hide resolved
@AaronRecord AaronRecord marked this pull request as ready for review November 11, 2021 02:12
@AaronRecord AaronRecord requested review from a team as code owners November 11, 2021 02:12
@akien-mga akien-mga force-pushed the 3.x branch 2 times, most recently from 71cb8d3 to c58391c Compare January 6, 2022 22:40
@Chaosus Chaosus self-requested a review January 7, 2022 13:45
@akien-mga akien-mga merged commit aad12a2 into godotengine:3.x Jan 7, 2022
@akien-mga
Copy link
Member

Thanks!

akien-mga added a commit that referenced this pull request Jan 7, 2022
@akien-mga
Fixup class reference after #54824
4737f56
@AaronRecord AaronRecord deleted the backport-gradient-texture-2d branch January 8, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xrayez Xrayez Xrayez left review comments

@Chaosus Chaosus Chaosus approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
5 participants
@AaronRecord @Xrayez @akien-mga @Chaosus @Geometror