Rename TabBar's tab_closed signal to tab_close_pressed
#54328
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YeldhamDev
force-pushed
the
tabbar_close_signal_rename
branch
from
13ce7fe to
a960ab9
Compare
anthonymartino
approved these changes
Oct 28, 2021
akien-mga
reviewed
Oct 28, 2021
YeldhamDev
force-pushed
the
tabbar_close_signal_rename
branch
from
a960ab9 to
4c563a5
Compare
mhilbrunner
approved these changes
Oct 29, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the close button of tab in
TabBardoesn't do anything on its own, requiring the developer to implement the code themselves. This rename (and documentation change) is to prevent any misleading.Bugsquad edit: Related to #16863