[3.x] Fixes crash caused by calling ColorPickerButton.propagate_notification(33)
#54170
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubonnek
changed the title
ColorPickerButton.propagate_notification(33)ColorPickerButton.propagate_notification(33)
akien-mga
reviewed
Oct 24, 2021
miraz12
force-pushed
the
fix-color-picker-notification33-crash
branch
from
959c025 to
35eeafd
Compare
akien-mga
approved these changes
Oct 25, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nullptr crash caused by calling
ColorPickerButton.propagate_notification(33).Fixes #54168
Already fixed in master but not easily cherry-picked. If it is I will remove this PR instead.