-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docs about plugin registration #53836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can take this opportunity to unify the descriptions even further. But otherwise seems good.
bea1bd5
to
684995e
Compare
684995e
to
7515af8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pluralizing cross-references like that often looks ugly and doesn't help with localizations, but it's not critical right now. 🙃
Thanks! |
This could use a dedicated cherry-pick PR, there's a number of conflicts and renamed classes to handle. |
Closes godotengine/godot-proposals#195
The docs for EditorExportPlugin were filled, but they didn't mention the most important thing - that you need to register the plugin for any method to be called.
I also made the same changes to other similar plugins, unifying it a bit.