-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SkeletonEditor's methods to adapt new animation and skeleton system #53786
Fix SkeletonEditor's methods to adapt new animation and skeleton system #53786
Conversation
06bbf0b
to
81b3a64
Compare
Fixed bugs and refactored. However, the animation track insertion is still broken. To fix that, a new UI needs to be generated, so I will send an additional PR later. The previous Quaternions are difficult to manipulate in the Inspector, so that problem needs to be fixed. Since @reduz is planning to implement rotation modes other than just YXZ Euler and Quaternion in the future, related to that, we are discussing whether we need to implement an There is also a problem with global scaling changing the Rotation, which needs to be addressed in the future, for example, such as #53684. |
62b7662
to
70e555e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference is to have Bone Transform visible by default, since the user selected the bone to see its transform.
pose_editor->set_visible(false);
I would also like the button for "apply pose to rest" to be moved, since it is now more important than before, but far away from the Rest matrix in the inspector that it would modify.
70e555e
to
8e9897b
Compare
Maybe, what @lyuma means is |
Thanks! |
#53689 and #53765 make big changed the methods of Skeleton and some SkeletonEditor's functions has broken, so I'll fix that.