Fix physical bone generation offset #53515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a physical skeleton, the generated bones were offset on the wrong axis.
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
|
@Calinou @akien-mga this seems like a no-brainer merge |
|
Related to this PR? |
|
I guess this is not a complete solution since the other PR linked involves more complex steps? |
akien-mga
added
the
cherrypick:3.5
|
In the I don't know if this current PR is a good enough stopgap solution in lieu of the above, or if we should instead aim for having it all backported. Someone would need to volunteer for the latter. |
|
Actually @Blackiris did a backport of #48310 in #48327, which was merged for 3.5. This seems to supersede this PR. I confirmed that #53466 is now fixed in 3.5. |
akien-mga
added
archived
and removed
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a physical skeleton, the generated bones were offset on the wrong axis.
Fixes #53466
Godot 4.0 doesn't show this behaviour anymore, this fix only applies to 3.x.
Big thanks to @lyuma who helped by testing, explaining and debugging!