Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an intermediate animation importer #53473

Closed

Conversation

reduz
Copy link
Member

@reduz reduz commented Oct 6, 2021

  • Animation importer now goes through an intermediate class
  • Allows centralizing all animation compression and optimization
  • Allows better access to animation data by scene importer plugins

This work is WIP

@reduz reduz marked this pull request as draft October 6, 2021 13:07
@Calinou Calinou added this to the 4.0 milestone Oct 6, 2021
@reduz reduz force-pushed the intermediate-animation-importer branch from 2eabc23 to 8de62ec Compare October 7, 2021 23:46
@fire
Copy link
Member

fire commented Oct 8, 2021

  1. Lyuma: Can I ask what the Vector3::AXIS_X argument means when adding blend shape tracks?

animation->node_track_add_axis_key(track_idx, ImporterAnimation::TRACK_TYPE_BLEND_SHAPE_KEY_0 + weight_i, Vector3::AXIS_X, t, b, 0, a, 0, c);

📛 reduz 📛: Lyuma blend shapes just use the X axis, ignore the others

Lyuma: does it store 0 for the other axes?

📛 reduz 📛: yeah, well more like nothing is stored

I guess it's just an in memory format so it doesn't matter if it stores unused axes?

📛 reduz 📛 yes internally nothing is stored if the channel is not used

  1. Lyuma: might suggest to rename the struct Node to a more unique name that isn't a widely used base type.

  2. Fire: Do we want to handle the case of non-equally spaced quaternions? This can be solved by quaternion squad or others. Squad is defined here https://github.com/KhronosGroup/glTF/blob/b6a148cf742efd8e1e1bb0457e6e2a5989b1c387/extensions/2.0/Vendor/EXT_animation_sqlerp/README.md#cubicslerp-interpolation

* Animation importer now goes through an intermediate class
* Allows centralizing all animation compression and optimization
* Allows better access to animation data by scene importer plugins

This work is WIP
@reduz
Copy link
Member Author

reduz commented Oct 11, 2021

Closed in favor of #53689

@reduz reduz closed this Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants