Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix crash when tooltip_request_func object is freed #53461

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

timothyqiu
Copy link
Member

3.x version of #53460.

  • set_tooltip_request_func() is not exposed to scripts on 3.x, but the implementation is the same, so it's still crashable if something goes wrong in C++ code.
  • ObjectID is a plain integer on 3.x, so it needs explicit initialization.

@timothyqiu timothyqiu requested a review from a team as a code owner October 6, 2021 06:46
@timothyqiu timothyqiu force-pushed the tooltip-request-func-3.x branch 2 times, most recently from 0d3a196 to 2ef33ee Compare October 6, 2021 07:26
@akien-mga
Copy link
Member

Sorry I'm the one who broke the build, in my shame I'm going to force push a fixup to the cherry-picked commit I pushed earlier.

@akien-mga
Copy link
Member

Should be fixed now (you'll have to do some creative rebasing to remove the bad cherry-pick from your branch).

@timothyqiu timothyqiu force-pushed the tooltip-request-func-3.x branch from 2ef33ee to 52a840b Compare October 6, 2021 07:55
@akien-mga akien-mga merged commit 3e2bb41 into godotengine:3.x Oct 6, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added this to the 3.4 milestone Oct 6, 2021
@timothyqiu timothyqiu deleted the tooltip-request-func-3.x branch October 6, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants