Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some leftover references to idle_frame #53406

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Fix some leftover references to idle_frame #53406

merged 1 commit into from
Oct 4, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 4, 2021

#44593 left some references to "idle_frame" signal, one of them was spamming errors in the animation editor.

@KoBeWi KoBeWi added this to the 4.0 milestone Oct 4, 2021
@KoBeWi KoBeWi requested review from a team as code owners October 4, 2021 18:59
fire
fire reviewed Oct 4, 2021
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspection of the code looks good, did not run demos.

@akien-mga akien-mga merged commit ad08483 into godotengine:master Oct 4, 2021
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the are_you_a_process_or_an_idle branch October 4, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @akien-mga @fire