Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ClippedCamera3D #53354

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Remove ClippedCamera3D #53354

merged 1 commit into from
Oct 4, 2021

Conversation

reduz
Copy link
Member

@reduz reduz commented Oct 3, 2021

  • Usage was always confusing for users
  • The ability to generate a pyramid shape was moved to Camera3D
  • SpringArm3D now casts using the camera pyramid shape if no shape is supplied.

@reduz reduz requested review from a team as code owners October 3, 2021 11:54
@QbieShay
Copy link
Contributor

QbieShay commented Oct 3, 2021

Note that this makes impossible to use just the raycast shape with the camera. I personally don't find it an issue.

@reduz reduz force-pushed the remove-clipped-camera branch from 030b498 to 39d84ea Compare October 3, 2021 14:19
@reduz reduz requested a review from a team as a code owner October 3, 2021 14:19
@reduz
Copy link
Member Author

reduz commented Oct 3, 2021 •
edited
Loading

@QbieShay Yeah, you can no longer use raycast with the camera, but I think it makes sense as now the camera always projects the correct pyramidal volume, hence it is impossible it goes behind geometry, whereas with the the raycast there is no warranty.

@QbieShay
Copy link
Contributor

QbieShay commented Oct 3, 2021

Yes, I don't think raycasting with camera is enough of a usecase for us to worry about it. Good work!

@Calinou Calinou added this to the 4.0 milestone Oct 3, 2021
@Calinou
Copy link
Member

Calinou commented Oct 3, 2021 •
edited
Loading

This can be done in a future PR, but the scene conversion code should probably convert existing ClippedCamera (3.x) and ClippedCamera3D (early master) nodes to plain Camera3D nodes. This way, you don't lose your camera settings when porting a project to Godot 4.

This should also be done with InterpolatedCamera.

aaronfranke
aaronfranke reviewed Oct 3, 2021
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot more sense this way, and works as expected.

scene/3d/spring_arm_3d.cpp Show resolved Hide resolved
scene/3d/spring_arm_3d.cpp Show resolved Hide resolved
doc/classes/Camera3D.xml Outdated Show resolved Hide resolved
@reduz
Remove ClippedCamera3D
b11bb59 
* Usage was always confusing for users
* The ability to generate a pyramid shape was moved to Camera3D
* SpringArm3D now casts using the camera pyramid shape if no shape is supplied.
@reduz reduz force-pushed the remove-clipped-camera branch from 39d84ea to b11bb59 Compare October 4, 2021 13:47
@akien-mga akien-mga merged commit 7722048 into godotengine:master Oct 4, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Dec 9, 2021
Closed
@Lippanon Lippanon mentioned this pull request Dec 8, 2022
Open
@Calinou Calinou mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:core topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@reduz @QbieShay @Calinou @akien-mga @aaronfranke