Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RichTextLabel not correctly returning text with get_text() #53282

Closed
wants to merge 1 commit into from
Closed

Fix RichTextLabel not correctly returning text with get_text() #53282

wants to merge 1 commit into from

Conversation

YeldhamDev
Copy link
Member

Fixes a bug with the match counter on help pages not updating.

Regression from #39148.

@YeldhamDev YeldhamDev added this to the 4.0 milestone Oct 1, 2021
@YeldhamDev YeldhamDev requested a review from a team as a code owner October 1, 2021 05:01
@akien-mga
Copy link
Member

CC @HaSa1002

bruvzg
bruvzg requested changes Oct 1, 2021
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what get_parsed_text() is doing, I guess help pages should use it instead.

@HaSa1002
Copy link
Contributor

HaSa1002 commented Oct 1, 2021

What should I say? bruvzg is correct. I forgot to search for get_text in the codebase and only searched for get_bbcode.

@YeldhamDev
Copy link
Member Author

I see. Will close this and open a new PR with that change.

@YeldhamDev YeldhamDev closed this Oct 1, 2021
@YeldhamDev YeldhamDev deleted the rtl_text_fix branch October 1, 2021 15:41
@YeldhamDev YeldhamDev removed this from the 4.0 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg requested changes

Assignees
No one assigned
Labels
archived bug regression topic:gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YeldhamDev @akien-mga @HaSa1002 @bruvzg