Don't override KinematicCollision reference when still in use in script #52954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the reference is stored in script, create a new instance to avoid overriding the previous values. Otherwise, re-use the reference as before to avoid extra allocations.
|
Wouldn't it be better to return a copy of the collision when accessing from script? This way you wouldn't need to worry if it's used or not. |
That would mean doing an allocation on each call, whereas checking for references allows the original optimization to still work in common cases. |
akien-mga
approved these changes
Sep 23, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the reference is stored in script, create a new instance to avoid overriding the previous values.
Otherwise, re-use the reference as before to avoid extra allocations.
Fixes #36290