In nodes RichTextLabel and Label, get_total_character_count() now has a parameter to include or not spaces

[Lucas3H]

The default value of this new parameter is true.

This was made mainly because the behavior of the function was inconsistent with the description in the documentation.

Fixes #27896.

[YeldhamDev]

Commits need to be squashed: https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html#the-interactive-rebase

[akien-mga]

Same comment as above.

[bruvzg]

The code is fine, but I do not see why this is useful to have.
Not counting spaces in the 3.x Label is probably a bug.

[Lucas3H]

The code is fine, but I do not see why this is useful to have.
Not counting spaces in the 3.x Label is probably a bug.

In fact, it doesn't look useful to add this new parameter. The reason I did it was because it shouldn't count spaces, accordingly to the previous documentation, but it was counting. It would be simpler to just fix the documentation, but maybe there are some places where this function was used supposing it is counting spaces and some places where it isn't.

Is it better to just fix the documentation?

But yeah, definitely a PR in the 3.x would be way more clear that it is fixing a bug. Can I do this already? I read that all fixes should be done first in master branch.

[YuriSizov]

So it seems that there is no need to change anything in the master branch. A fix for a bug in 3.x doesn't need to have a master counterpart, so a direct PR can be opened. For either branch if we can improve the docs, a new PR doing that is welcome 🙂