Add support for CTRL + ALT + special character #52452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometror
force-pushed
the
ctrl-shift-spchar
branch
from
e0fc79a to
68fc390
Compare
Paulb23
reviewed
Sep 9, 2021
There was a problem hiding this comment.
Been doing some reading on this, I'm not sure 100% sure yet what the correct fix is but this doesn't seem right.
I have a feeling we might need #43888 first, I need to get a Windows dev environment set up so I can take better look at the API.
This was referenced Jan 11, 2022
|
Superseded by #56695. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to implement/fix #6851 again (hopefully without any regressions):
By removing the accept_event call all shortcuts which are using the exact same keys do still work. I could not notice any regressions on Windows 10, but further testing is required. Note that if a shortcut consists of Ctrl + Alt + [some key used for a special character], the character input is handled AND the command associated to the shortcut is executed.
Testing/feedback is welcome :)