glTF2 use alpha, alpha to coverage and depth prepass #52407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
changed the title
fire
force-pushed
the
gltf-alpha
branch
2 times, most recently
from
c9abc49 to
4b5e8be
Compare
fire
changed the title
fire
force-pushed
the
gltf-alpha
branch
2 times, most recently
from
609e126 to
f22af86
Compare
clayjohn
reviewed
Sep 9, 2021
| material->set_transparency(BaseMaterial3D::TRANSPARENCY_ALPHA_SCISSOR); | ||
| material->set_alpha_antialiasing(BaseMaterial3D::ALPHA_ANTIALIASING_ALPHA_TO_COVERAGE_AND_TO_ONE); |
There was a problem hiding this comment.
I'm not sure if this is the best approach. Won't this only work when MSAA is enabled? E.g. when alpha to coverage is available?
There was a problem hiding this comment.
According to the originator, it works when msaa is off.
https://bgolus.medium.com/anti-aliased-alpha-test-the-esoteric-alpha-to-coverage-8b177335ae4f
<Ben Golus> In fact if MSAA is disabled Alpha to Coverage falls back to alpha test. This means it isn’t only useful for VR or other games where you’re guaranteed to have MSAA enabled. Basically there’s rarely a reason to use straight alpha testing ever!
|
Closing for now due to need to reevaluate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0bdbce6
For https://github.com/KhronosGroup/glTF-Sample-Models/tree/master/2.0/AlphaBlendModeTest cases.
Fixes the second case of blending from gltf2 test case.
Fixes hair for the the blend case.
Not fixed in the PR: Alpha being order independent transparency.