Rename String::is_rel_path to String::is_relative_path
#52240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubonnek
changed the title
String::is_rel_path to String::is_relative_path
|
Can you also rename the C# version in |
Rubonnek
force-pushed
the
rename-rel-path
branch
from
c99aff7 to
d11c1af
Compare
Done |
aaronfranke
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #49279.
See #16863 (comment).
See #49279 (comment).
For what is worth, I also find the abbreviation confusing now that
String::is_absolute_pathis not abbreviated anymore inmaster.