Fix doctool merges when method signatures don't match #51982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduz
force-pushed
the
fix-doctool-merging-when-signatures-change
branch
from
987c3b0 to
e96a877
Compare
YuriSizov
approved these changes
Aug 22, 2021
reduz
force-pushed
the
fix-doctool-merging-when-signatures-change
branch
from
e96a877 to
fb89564
Compare
If methods signature did not match, documentation is not merged. This is a considerable source of annoyance for contributors and it happened as a result of godotengine#4533, otherwise the documentation for constructors would not be properly merged. This PR modifies the logic introduced to only do the signature test on constructors and operators (which are the only types of members that can repeat).
reduz
force-pushed
the
fix-doctool-merging-when-signatures-change
branch
from
fb89564 to
431ba0e
Compare
mhilbrunner
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If methods signature did not match, documentation is not merged. This is
a considerable source of annoyance for contributors and it happened as
a result of #4533, which was needed as, otherwise, the documentation for
constructors would not be properly merged.
This PR modifies the logic introduced to only do the signature test on
constructors and operators (which are the only types of members that can repeat).