-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename remove()
to remove_at()
when removing by index
#50139
Rename remove()
to remove_at()
when removing by index
#50139
Conversation
cac170f
to
e993888
Compare
154aa85
to
e60a2d4
Compare
remove
to remove_at
remove()
to remove_at()
when removing by index
bf3c5d6
to
8784605
Compare
8784605
to
e533e37
Compare
71f0203
to
4b4fae9
Compare
Rebased. There's still a number of methods (e.g. https://github.com/godotengine/godot/blob/master/editor/editor_data.cpp#L538, |
9489e6e
to
b2a9d5a
Compare
(rebased) @aaronfranke Also I wonder if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea.
This was approved in PR review meeting (sorry for the delay), it just needs a rebase (or redo if that's easier). |
b2a9d5a
to
2ba7a54
Compare
rebased. |
2ba7a54
to
e078f97
Compare
Thanks! |
Part of #16863
Closes godotengine/godot-proposals#2885