Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to 2D viewport #50007

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Fixes to 2D viewport #50007

merged 1 commit into from
Jun 29, 2021

Conversation

reduz
Copy link
Member

@reduz reduz commented Jun 29, 2021

  • Editor 2D viewport now uses embedded subwindows (windows no longer pop up)
  • Restored the ability to disable 3D on the 2D viewport (makes 3D not display on 2D when there is a camera on the scene)

Bugsquad edit: Fixes #40553

@reduz reduz requested review from a team as code owners June 29, 2021 16:38
@Calinou Calinou modified the milestones: 3.4, 4.0 Jun 29, 2021
@Calinou
Copy link
Member

Calinou commented Jun 29, 2021

Restored the ability to disable 3D on the 2D viewport (makes 3D not display on 2D when there is a camera on the scene)

We may want to expose an option in the 2D editor for this, since seeing a 3D background can sometimes be useful for designing HUDs in real world conditions. This can be exposed in a future PR.

@reduz reduz force-pushed the fix-2d-viewport branch from aa00501 to cc825da Compare June 29, 2021 17:09
@reduz reduz requested a review from a team as a code owner June 29, 2021 17:09
@KoBeWi
Copy link
Member

KoBeWi commented Jun 29, 2021

Editor 2D viewport now uses embedded subwindows (windows no longer pop up)

Is it supposed to fix dialog display? Dialogs don't appear at all and windows are like this
image

scene/main/viewport.cpp Outdated Show resolved Hide resolved
* Editor 2D viewport now uses embedded subwindows (windows no longer pop up)
* Restored the ability to disable 3D on the 2D viewport (makes 3D not display on 2D when there is a camera on the scene)
@reduz reduz force-pushed the fix-2d-viewport branch from cc825da to d07f7c8 Compare June 29, 2021 20:42
@reduz
Copy link
Member Author

reduz commented Jun 29, 2021

@KoBeWi This is mostly because it does not have anything to draw and there is no default theme for embedded windows. Additionally, subwindows/dialogs are not editable(I don't think they ever were). Would be nice if they were but likely all this is material for a separate PR.

@akien-mga akien-mga merged commit 03788e9 into godotengine:master Jun 29, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera3D view visible in 2D editor
5 participants