[3.x] Fix move_and_collide causing sliding on slopes #49902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
force-pushed
the
move-and-collide-fix-slide-3.x
branch
2 times, most recently
from
7173eb1 to
5cccae9
Compare
|
Converted to draft because on second thought, this could be too big of a change to be backported to 3.x. Once |
pouleyKetchoupp
force-pushed
the
move-and-collide-fix-slide-3.x
branch
from
5cccae9 to
68897dd
Compare
Make sure the direction of the motion is preserved, unless the depth is higher than the margin, which means the body needs depenetration in any direction. Also changed move_and_slide to avoid sliding on the first motion, in order to avoid issues with unstable position on ground when jumping. Co-authored-by: fabriceci <[email protected]>
pouleyKetchoupp
force-pushed
the
move-and-collide-fix-slide-3.x
branch
from
68897dd to
2c17490
Compare
|
Closing in favor of #50495, which also includes more recent fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the direction of the motion is preserved in
move_and_collide, unless the depth is higher than the margin, which means the body needs depenetration in any direction.Credits to @fabriceci for investigating move and slide issues and helping with extensive testing.
3.x backport of #49901 (see more details there).