Rename instance()->instantiate() when it's a verb

[AaronRecord]

See #16863 (comment)

[YuriSizov]

Shouldn't there be a change in the documentation as well?

[Xrayez]

I'm not particularly against the rename, but it's not only about simple refactor thing. The entire codebase should be reviewed for usage of "instance" word, including comments.

The existing "instance" word sounds fine to me (and is easier to type), but I'm not a native speaker. English allows to use nouns as verbs, so that's why it probably sounds natural to me:

https://en.wikipedia.org/wiki/Buffalo_buffalo_Buffalo_buffalo_buffalo_buffalo_Buffalo_buffalo

It also depends on how you interpret method names. instance() can be used as a noun for an action that returns the already instantiated object, like in next_instance() (does not exist in Godot, that's just to give an example). instance() can also be interpreted as a shorthand for create_instance(), where create implicitly acts as a verb.

I guess it's a problem of being explicit and being too verbose. That's why I prefer that we don't rename existing methods. But if we do, we should recognize the right context and rename existing methods accordingly (with the possiblity to remain existing instance() name as-is, where appropriate).

[YuriSizov]

The existing "instance" word sounds fine to me (and is easier to type), but I'm not a native speaker. English allows to use nouns as verbs, so that's why it probably sounds natural to me

Yes, it does sound valid, but probably because "instance" can actually be used as a verb, but it has an unrelated meaning.

[AaronRecord]

I think instantiate() makes more sense than instance() for meaning "create an instance of ...". Without context, instance() could mean get_instance() or is_instance().

[fire]

I can see myself typoing a bit with this compared to instance.

Would mistakenly rearrange the vowels.

[AaronRecord]

Should I open a proposal for this? The comment has +24 -0 likes/dislikes, so I'm not sure if it's necessary.

[AaronRecord]

(rebased following #44806)

[akien-mga]

Needs another rebase as I merged a bunch of PR (+ a couple might have added new calls to instance() to change).

Then I'll merge this PR first :)

[AaronRecord]

Okay I think everything should be good to go.

[akien-mga]

Thanks!