Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for _language in PluginScript.instance_has #49191

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented May 29, 2021

This should fix #46020. I managed to get the error in master, but this is easy to cherry-pick to 3.x.

@pfertyk pfertyk requested a review from a team as a code owner May 29, 2021 16:35
@Calinou Calinou added bug crash topic:gdextension cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels May 29, 2021
@Calinou Calinou added this to the 4.0 milestone May 29, 2021
@AaronRecord
Copy link
Contributor

AaronRecord commented May 30, 2021

You'll probably want to squash the commits.

@pfertyk pfertyk force-pushed the issue-46020-pluginscript-instance-has-crashes-godot branch from ebdf9c0 to a76262e Compare May 30, 2021 20:15
@pfertyk pfertyk requested review from a team as code owners May 30, 2021 20:15
@pfertyk pfertyk force-pushed the issue-46020-pluginscript-instance-has-crashes-godot branch from a76262e to 4b25892 Compare May 30, 2021 20:21
@pfertyk
Copy link
Contributor Author

pfertyk commented May 30, 2021

@LightningAA done :)

@YeldhamDev YeldhamDev removed request for a team May 30, 2021 20:23
@YeldhamDev YeldhamDev removed request for a team May 30, 2021 20:23
@akien-mga akien-mga merged commit 652a9de into godotengine:master May 31, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 31, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing PluginScript.new().instance_has(BoxShape.new()) crashes Godot
4 participants