Check cache_parent_physical_bone when rebuilding parent cache #49182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
cherrypick:3.3
cherrypick:3.x
akien-mga
approved these changes
May 31, 2021
|
Thanks! |
|
Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating the parent bone cache, checking whether the parent bone equals itself makes no sense. I believe this is a typo that existed for quite a long time. CC @AndreaCatania
This PR also applies to the
3.xbranch. It helps to solve the strange offset of lastPhysicalBoneafter fixing the bone ID (see #48705). Themasterbranch does not have this offset because the joint is always reloaded at the end ofENTER_TREEafter the multithread refactoring.