Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix valign with stylebox borders #49011

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix valign with stylebox borders #49011

merged 1 commit into from
Jun 15, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 23, 2021

Fixes #39923

@KoBeWi KoBeWi added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:gui labels May 23, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone May 23, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner May 23, 2021 20:40
@akien-mga akien-mga merged commit 1129439 into godotengine:master Jun 15, 2021
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the totally_h branch June 15, 2021 14:33
@akien-mga
Copy link
Member

The change doesn't cherry-pick properly to 3.x as the code that recalculates total_h is from CTL.

@KoBeWi KoBeWi mentioned this pull request Jul 15, 2021
Merged
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Label's Valign property ignores bottom border of stylebox
2 participants
@KoBeWi @akien-mga