Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on gltf export.
Fixes: #47121
GLTF Export blend shape notes from Lyuma
This code is invalid:
If TANGENT is encoded as vec3, the w component should be dropped, not multiplied.
This code has a bug:
Should be if(narr.size()) {
Line 6262: If we encounter another :blend_shapes/ track for a mesh whose blend shapes we have already exported, we must avoid exporting the blend shapes for that mesh a second time.
keyframes should be capped at a constant * the original number of keyframes. for example, min of 1.0 / BAKE_FPS and (total length / (10 * number of keyframes))
We should check if tracks are linear and avoid the complicated baking cases.
Line 6358: change to if key_count == 0: Why two zeros? I think we should do only one key