Expose ImportDock and its children #47985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trollodel
force-pushed
the
hackable_importdock
branch
2 times, most recently
from
452dc6e to
0387e38
Compare
KoBeWi
reviewed
Aug 18, 2021
Comment on lines
+186
to
+189
| if (p_paths.is_empty()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Should probably emit edited_paths_changed no? Same with single edit.
|
Code seems fine. Needs rebase, so it can be tested etc. Also like in #47767, I don't see a way to actually get the import dock. |
trollodel
force-pushed
the
hackable_importdock
branch
from
0387e38 to
931b255
Compare
trollodel
force-pushed
the
hackable_importdock
branch
from
931b255 to
e66a805
Compare
|
Closing per discussion in the Godot contributor chat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of godotengine/godot-proposals#2537
Indipendent from #47520
Expose ImportDock, including a bunch of method for interacting with it.
Considerations for docs are the same of #47767.