Style: Apply selected clang-tidy checks #47642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Apr 5, 2021
| /** enable strict mode: | ||
| * - only accept fbx 2012, 2013 files | ||
| * - on the slightest error, give up. | ||
| * | ||
| * Basically, strict mode means that the fbx file will actually | ||
| * be validated. Strict mode is off by default. */ |
There was a problem hiding this comment.
@RevoluPowered I removed mentions of default values since they're better documented by the code itself (and this one was wrong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies changes from our
.clang-tidyconfig with/usr/share/clang/run-clang-tidy.py -fix. Note that to keep them in separate commits I edited.clang-tidyto apply checks one by one (could also be done from command line but didn't bother looking it up).Still a painful process as:
clang-tidyproperly ignorethirdpartybool some_member = false = false;orif (cond) { {which need to be reviewed and fixed manually.