[HTML5] Make debug server more maintainable, better icon export. #47386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
commented
Mar 26, 2021
|
Needs rebase after #47435 |
Faless
force-pushed
the
js/4.x_http_server_refactor
branch
from
103d278 to
9e7dd79
Compare
akien-mga
reviewed
Apr 26, 2021
akien-mga
approved these changes
Apr 27, 2021
Faless
force-pushed
the
js/4.x_http_server_refactor
branch
2 times, most recently
from
61feb03 to
5872fc7
Compare
Serving all files in that folder and using a known list of mime types. Makes it easy to add more exported files, while still playing safe.
We used to only generate the favicon if it was specified in the user project settings, now it's optional, will export it to `NAME.icon.png`, (falling back to the default project icon if none is set in project settings), and the `<link>` tag is added using the `$HEAD_INCLUDE` instead of being hardcoded in the template.
Faless
force-pushed
the
js/4.x_http_server_refactor
branch
from
5872fc7 to
5d095ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Debug HttpServer now runs in
webcache subdir.Serving all files in that folder and using a known list of mime types. Makes it easy to add more exported files, while still playing safe.
Optional icon generation, use export name for it.
We used to only generate the favicon if it was specified in the user project settings, now it's optional, will export it to
NAME.icon.png, (falling back to the default project icon if none is set in project settings), and the<link>tag is added using the$HEAD_INCLUDEinstead of being hardcoded in the template.There is a
3.xversion here: https://github.com/Faless/godot/tree/js/3.x_http_server_refactorLikely
3.4material, since I don't want to break anything in the long awaited3.3:) .