Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DynamicFont breaking mouse grab in inspector spinners #47235

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

opl-
Copy link
Contributor

@opl- opl- commented Mar 21, 2021

This was caused by DynamicFont not specifying which property was edited, resulting in the whole inspector being recreated

Fixes #25046. Same as #40701 but targeting the 3.x branch.

@Calinou Calinou added this to the 3.4 milestone Mar 21, 2021
@akien-mga akien-mga requested a review from a team March 23, 2021 10:51
@akien-mga akien-mga requested a review from bruvzg April 8, 2021 09:36
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, but needs rebase.

This was caused by DynamicFont not specifying which property was edited, resulting in the whole inspector property tree being recreated.
@akien-mga akien-mga merged commit c33ff6b into godotengine:3.x Sep 16, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants